Require a minimum confirmation count for beacon transactions - #338
Merged
jintekc merged 3 commits intoJul 29, 2026
Merged
Conversation
Resolvers had no rule for unconfirmed or under-confirmed beacon transactions, so implementations diverged on whether mempool signals count towards resolution. Require at least resolutionOptions.minConf confirmations, defaulting to the industry-standard 6, before a transaction is processed. Resolution requests can raise or lower minConf to match their own threat and security model. minConf is floored at 1: mempool contents are node-local, unordered, and replaceable, so an unconfirmed transaction never counts towards resolution regardless of options.
danpape
previously approved these changes
Jul 29, 2026
parasyte
previously approved these changes
Jul 29, 2026
parasyte
left a comment
parasyte
left a comment
Collaborator
There was a problem hiding this comment.
Good change. I left some grammatical nitpicks.
Refine wording for `minConf` defintion Co-authored-by: Jay Oster <jay@blipjoy.com>
Wording refinement similar to `minConf` definition Co-authored-by: Jay Oster <jay@blipjoy.com>
Collaborator
Author
|
Grammatical nitpicks applied. Ready for re-review. |
parasyte
approved these changes
Jul 29, 2026
danpape
approved these changes
Jul 29, 2026
jintekc
deleted the
spec-change/determine-target-blockheight-how-many-confs-#37
branch
July 29, 2026 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the confirmation rule discussed in the issue: a beacon transaction MUST be included in a Bitcoin block and have at least resolutionOptions.minConf confirmations (default 6) to count towards resolution. minConf is floored at 1: mempool contents are node-local, unordered, and replaceable (RBF), so unconfirmed transactions never count regardless of options. A footnote explains that 6 is the broadly accepted settlement standard and that lowering minConf trades reorg exposure, which consumers can evaluate from the REQUIRED confirmations metadata. The Resolution Options data structure and example gain the new minConf property.
Closes #37