fix(cli): Keep reasoning shading across a stream retry - #931
Merged
Conversation
When a stream error interrupts a reasoning block, JP resends the request and continues the same response. The renderer used to treat that boundary like a normal flush, closing the reasoning region and rendering the gap it owed as an unshaded strip before the continuation reopened the region. The background now visibly breaks around a retry even though the reasoning is one continuous block. `TurnCoordinator::commit_partial_response` now calls `flush_renderer_for_continuation` instead of `flush_renderer`. The chat renderer's new `flush_for_continuation` commits buffered content like a normal flush but keeps the deferred separator shaded when the last content written was reasoning, so the gap stays inside the region and the continuation's output lands on the same background. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a stream error interrupts a reasoning block, JP resends the request and continues the same response. The renderer used to treat that boundary like a normal flush, closing the reasoning region and rendering the gap it owed as an unshaded strip before the continuation reopened the region. The background now visibly breaks around a retry even though the reasoning is one continuous block.
TurnCoordinator::commit_partial_responsenow callsflush_renderer_for_continuationinstead offlush_renderer. The chat renderer's newflush_for_continuationcommits buffered content like a normal flush but keeps the deferred separator shaded when the last content written was reasoning, so the gap stays inside the region and the continuation's output lands on the same background.