rename DCM_API_GATEWAY_URL env to DCM_API_URL#7
Open
gciavarrini wants to merge 1 commit into
Open
Conversation
Part of FLPATH-4424. Merge after rhdh-plugins and control-plane. Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
requested review from
chadcrum,
ddmitrie,
gabriel-farache,
hardengl,
jenniferubah,
machacekondra,
pkliczewski,
testetson22 and
y-first
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
dcm-uiquadlet env var fromDCM_API_GATEWAY_URLtoDCM_API_URL, matching the control-plane monolith naming from.The URL value is unchanged (
http://control-plane:8080).Part of FLPATH-4424.
dcm-uiimageWhy
verify_compose_alignment.ymlis unchangedJira lists two quadlet files, but the verify playbook does not hardcode env var names. It clones upstream
control-plane/deploy/compose.yamland compares compose env keys to quadlet templates at runtime. Once control-planemainusesDCM_API_URL, the existing assert covers the new name with no alias or mapping. A verify edit is only needed when PRsland out of order; we merge in sequence, so no change here.
--
Assisted-By: Claude (Anthropic)
Signed-off-by: Gloria Ciavarrini gciavarrini@redhat.com