Sink Particle Fixes#1
Open
AstroDnerd wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Create a pull request to help us improve
title: ''
labels:
assignees: ''
Pull request summary
Fixed position of new sink particles: Sinks were being formed in actual_cell_{x-1,y-1,z-1}
Fixed merging of sink particles: After a sink is created, it takes away mass from grid, causing it to derefine and leaving a sink in lower grid level which cannot merge with other higher level grid. Added merging across all levels.
Added SinkParticleDensityThresholdCriterion: Knob to play with the cell density threshold to form sinks