add mesos basic auth#169
Conversation
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 67.94% 67.92% -0.02%
==========================================
Files 55 55
Lines 3584 3588 +4
==========================================
+ Hits 2435 2437 +2
- Misses 1149 1151 +2
Continue to review full report at Codecov.
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
@andreaspeters, thanks a lot for your contribution! It is preferred not to supply individual configuration values through environment variables. Please refer to https://github.com/dcos/dcos-net/blob/master/apps/dcos_net/src/dcos_net_app.erl#L45 to learn more about the way By default, |
|
Hi @ichernetsky , thanks for your response. |
Merge with main
This PR will add the basic auth method to authenticate against the mesos master. Then the nice DC/OS net is also useful for "normal" mesos installations without authentication token. The authentication string have to be in a env variable and should looks like
MESOS_BASIC_AUTH="Basic <BASE64STRING>".