Improve network mode detection#64
Open
orlandohohmeier wants to merge 1 commit into
Open
Conversation
Adjust the network mode detection to properly handle cases without the `network-scope` label as the metrics collection would otherwise fail in those cases.
Author
|
@jkoelker @wavesoft would love a review from you on this one. Please note that it doesn't handle cases where the resources are reported on the executor as this would require additional requests which could degrade performance. Marathon pods launched on the host network would match this case but come with the network scope label and are thus already handled. P.S. You will want to implement a similar detection in Edge-LB for the auto-pool feature to properly handle different network modes. /cc @vinodkone |
jkoelker
reviewed
Apr 17, 2020
jkoelker
left a comment
There was a problem hiding this comment.
Logic wise LGTM, I'll have to look into the test failures later, it looks like the mocks just need to be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the network mode detection to properly handle cases without the
network-scopelabel as the metrics collection would otherwise fail in those cases.