Skip to content

Enforce maintained regression checks#183

Open
parsakhaz wants to merge 1 commit into
mainfrom
paseo-and-morph-inspo
Open

Enforce maintained regression checks#183
parsakhaz wants to merge 1 commit into
mainfrom
paseo-and-morph-inspo

Conversation

@parsakhaz
Copy link
Copy Markdown
Member

Summary

  • add PR CI coverage for root typecheck/lint, minimal Playwright smoke, and cross-OS main-process tests
  • replace stale browser smoke assumptions with a deterministic renderer preload mock
  • remove obsolete Playwright specs that no longer matched the current UI/test contract

Validation

  • ruby YAML parse for .github/workflows/quality.yml
  • pnpm typecheck
  • pnpm lint (passes with existing warnings)
  • CI=1 pnpm --filter main test
  • PANE_DIR=/tmp/pane-pr-ci-* xvfb-run -a pnpm test:ci
  • PANE_DIR=/tmp/pane-min-ci-* xvfb-run -a pnpm test:ci:minimal

Notes

  • Local shell reports Node 20.19.3, while repo requires >=22.14.0. CI uses Node 22.15.1.
  • The current Playwright suite is intentionally reduced to maintained smoke coverage. Broader real Electron IPC E2E should be rebuilt as a follow-up using a proper Electron harness.

@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant