Skip to content

feat: add daemon protocol primitives#185

Open
parsakhaz wants to merge 2 commits into
phase1-core-runtime-boundaryfrom
phase2-local-daemon-protocol
Open

feat: add daemon protocol primitives#185
parsakhaz wants to merge 2 commits into
phase1-core-runtime-boundaryfrom
phase2-local-daemon-protocol

Conversation

@parsakhaz
Copy link
Copy Markdown
Member

Summary

  • add shared Pane daemon request/response/event frame types and channel ownership helpers
  • add cross-platform local endpoint selection for Unix sockets and Windows named pipes
  • add a framed newline-delimited decoder/encoder with validation and focused tests

Testing

  • pnpm typecheck
  • pnpm lint
  • CI=1 pnpm --filter main test
  • PANE_DIR=/tmp/pane-phase2-daemon-ci xvfb-run -a pnpm test:ci

@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5423e100d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread main/src/daemon/socketFraming.ts Outdated
Copy link
Copy Markdown
Member Author

@codex review

Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant