Skip to content

Phase 2: route data-domain IPC through registry#187

Open
parsakhaz wants to merge 1 commit into
phase2-command-registry-corefrom
phase2-command-registry-data-domains
Open

Phase 2: route data-domain IPC through registry#187
parsakhaz wants to merge 1 commit into
phase2-command-registry-corefrom
phase2-command-registry-data-domains

Conversation

@parsakhaz
Copy link
Copy Markdown
Member

Summary

  • route project, prompt, and file daemon-owned IPC handlers through PaneCommandRegistry
  • keep file:showInFolder as an Electron-only adapter outside the daemon registry surface
  • add regression coverage for the migrated registry bindings

Validation

  • pnpm typecheck
  • pnpm lint
  • CI=1 pnpm --filter main test
  • PANE_DIR=/tmp/pane-phase2-command-registry-data-domains xvfb-run -a pnpm test:ci

Review

  • implementation review pass completed before opening this PR
  • no blocking findings for this slice

Notes

  • this is still an intentional partial of Phase 2 Task 2; session, panel, terminal, and script domains remain for later reviewed PRs

@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant