Skip to content

feat: deliver hidden terminal output to daemon clients#193

Open
parsakhaz wants to merge 1 commit into
phase2-local-daemon-server-bootstrapfrom
phase2-daemon-terminal-hidden-delivery
Open

feat: deliver hidden terminal output to daemon clients#193
parsakhaz wants to merge 1 commit into
phase2-local-daemon-server-bootstrapfrom
phase2-daemon-terminal-hidden-delivery

Conversation

@parsakhaz
Copy link
Copy Markdown
Member

Summary

  • add a daemon-only event sink to the runtime so Electron-visible delivery and daemon delivery can diverge where needed
  • keep visible terminal output on the existing fanout path while sending hidden terminal output only to daemon subscribers
  • add focused terminal manager regression coverage for visible vs hidden output delivery

Testing

  • pnpm typecheck
  • pnpm lint
  • CI=1 pnpm --filter main test
  • PANE_DIR=/tmp/pane-phase2-daemon-terminal-hidden-delivery xvfb-run -a pnpm test:ci

@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant