Skip to content

fix: restore live Electron daemon bridge boot#195

Open
parsakhaz wants to merge 3 commits into
phase2-daemon-bridge-preload-routingfrom
phase2-daemon-validation-hardening
Open

fix: restore live Electron daemon bridge boot#195
parsakhaz wants to merge 3 commits into
phase2-daemon-bridge-preload-routingfrom
phase2-daemon-validation-hardening

Conversation

@parsakhaz
Copy link
Copy Markdown
Member

@parsakhaz parsakhaz commented May 14, 2026

Summary

  • restore Electron preload startup after the daemon bridge split by keeping the renderer-side channel classifier runtime-safe under sandboxed preload constraints
  • register window:is-focused before the renderer loads so focus-state IPC no longer races app startup
  • keep the shared daemon channel ownership map authoritative for main/runtime code and add a regression check that preload's inline classifier stays aligned

Testing

  • pnpm typecheck
  • pnpm lint
  • CI=1 pnpm --filter main test -- --run
  • pnpm run build:main
  • PANE_DIR=/tmp/pane-phase2-final-ci xvfb-run -a pnpm test:ci
  • PANE_USE_PTY_HOST=1 PANE_DIR=/tmp/pane-phase2-live-smoke-ptyhost xvfb-run -a pnpm test:ci
  • PANE_DIR=/tmp/pane-phase2-review-smoke xvfb-run -a pnpm test:ci
  • live Electron smoke via direct launch and Playwright-attached renderer probes covering preload boot, getPlatform, getVersionInfo, project create/list, folder create/list, session create/list, and resource monitor snapshot

@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@parsakhaz parsakhaz changed the title test: harden daemon bridge boundary checks fix: restore live Electron daemon bridge boot May 14, 2026
@parsakhaz
Copy link
Copy Markdown
Member Author

@codex review

@parsakhaz
Copy link
Copy Markdown
Member Author

@claude review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant