feat: extract headless daemon host bootstrap#196
Open
parsakhaz wants to merge 1 commit into
Open
Conversation
Member
Author
|
@codex review |
Member
Author
|
@claude review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createPaneDaemonHost()host objectBrowserWindowindex.tsbootstrap assumptions from task queue, resource monitor, app-directory parsing, and panel webview context wiringWhat changed
main/src/daemon/bootstrap.tsto own service initialization, local daemon startup, runtime sink installation, and shared shutdownmain/src/daemon/headless.tsas the first headless Electron entrypoint for self-hosted daemon modemain/src/index.tsso desktop mode uses the extracted host instead of duplicating service startupTaskQueuechoose its local in-process queue without depending onprocess.versions.electronResourceMonitorServiceaccept injected session/app dependencies instead of requiring../index../indexValidation
pnpm typecheckpnpm lint(passes with existing repo warnings)CI=1 pnpm --filter main test -- --runpnpm run build:mainPANE_DIR=/tmp/pane-phase3-remote-smoke-final xvfb-run -a pnpm test:cimain/dist/main/src/daemon/headless.jswithout creating aBrowserWindow, confirmed the local daemon socket was announced, and confirmed clean externalSIGTERMexitReview note
Ctrl+Cagainst the Electron wrapper is still noisy in local shell smoke, but an externalSIGTERMto the Electron process exits cleanly after shutdown. I treated external signal stop as the meaningful daemon validation path for this slice.