Skip to content

fix: remove hardcoded API URL from frontend build #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcs-soni merged 1 commit into from
Nov 9, 2025
Merged

fix: remove hardcoded API URL from frontend build #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions .github/workflows/build-and-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,6 @@ jobs:
org.opencontainers.image.description=Taskerra Frontend Web Application
org.opencontainers.image.vendor=Taskerra

# Determine API URL based on branch
- name: Set API URL
id: api_url
run: |
if [[ "${{ github.ref }}" == "refs/heads/master" ]]; then
echo "VITE_API_URL=https://api.taskerra.com" >> $GITHUB_OUTPUT
else
echo "VITE_API_URL=http://localhost:3002/api/v1" >> $GITHUB_OUTPUT
fi

- name: Build and push Frontend image
uses: docker/build-push-action@v5
with:
Expand All @@ -168,8 +158,7 @@ jobs:
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=gha
cache-to: type=gha,mode=max
build-args: |
VITE_API_URL=${{ steps.api_url.outputs.VITE_API_URL }}
# Removed args as no VITE_API_URL needed - using relative URLs in production

- name: Output image details
run: |
Expand All @@ -178,7 +167,7 @@ jobs:
echo '```' >> $GITHUB_STEP_SUMMARY
echo "${{ steps.meta.outputs.tags }}" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
echo "**API URL:** ${{ steps.api_url.outputs.VITE_API_URL }}" >> $GITHUB_STEP_SUMMARY
echo "**API URL:** Relative URLs (/api/v1) - proxied by nginx" >> $GITHUB_STEP_SUMMARY

notify:
name: Notify Build Status
Expand Down