-
Notifications
You must be signed in to change notification settings - Fork 0
Clarify stable schema tokens for localized WATCHLIST entries #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| { | ||
| "id": "localized-schema-tokens-kr", | ||
| "prompt": "한국어로 작성하되 WATCHLIST.md에 추가해줘. 오늘 17:00에 CI 확인.", | ||
| "locale": "ko", | ||
| "fixed_now": "2026-05-14T16:30:00+09:00", | ||
| "fixture": "empty.watchlist.md", | ||
| "should_trigger_skill": true, | ||
| "expected": { | ||
| "operation": "add_item", | ||
| "status": "open", | ||
| "due_at": "2026-05-14T17:00:00+09:00", | ||
| "scheduler": "none", | ||
| "required_fields": [ | ||
| "source", | ||
| "trigger", | ||
| "action", | ||
| "done_when" | ||
| ], | ||
| "forbidden_response_substrings": [ | ||
| "I'll remind you", | ||
| "I will remind you", | ||
| "I'll check later", | ||
| "I will check later", | ||
| "자동으로 알려드릴게요", | ||
| "제가 나중에 확인할게요" | ||
| ], | ||
| "schema_tokens": { | ||
| "must_use_field_keys": [ | ||
| "schema_version", | ||
| "automation", | ||
| "timezone", | ||
| "status", | ||
| "priority", | ||
| "owner", | ||
| "due_at", | ||
| "created_at", | ||
| "source", | ||
| "trigger", | ||
| "action", | ||
| "done_when", | ||
| "last_checked_at", | ||
| "result", | ||
| "next_step_on_fail" | ||
| ], | ||
| "must_use_enum_values": [ | ||
| "open", | ||
| "P1", | ||
| "assistant_on_review" | ||
| ], | ||
| "must_not_use_localized_schema_tokens": [ | ||
| "상태", | ||
| "우선순위", | ||
| "담당자", | ||
| "기한", | ||
| "생성일", | ||
| "출처", | ||
| "계기", | ||
| "작업", | ||
| "완료조건", | ||
| "열림", | ||
| "어시스턴트" | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assertion for localized schema tokens is hardcoded to Korean words (
상태,우선순위, etc.). If non-Korean localized test cases (e.g.,-jpor-es) are added in the future, this validator will fail.We should condition this check so it only runs for Korean cases (e.g., by checking if
"-kr"is in thecase_id).