[codex] Harden document briefing cache distribution and grounding#1
Conversation
There was a problem hiding this comment.
Code Review
This pull request hardens the distribution and LLM integration of the document-briefing-cache skill by migrating templates to package resources, upgrading the document summary schema to version 1.1.0 to mandate evidence for all claims, and enhancing the OpenAI summarizer with chunking, retries, and production-oriented configuration flags. Documentation was also updated to clarify input boundaries and privacy guidance. Review feedback suggests improving the OpenAI retry logic with exponential backoff, expanding transient error detection to include SDK-specific connection and timeout exceptions, and ensuring the rule-based summarizer provides evidence when falling back to document titles.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9685e685ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
1.1.0, structured claim evidence checks, and stricter cache/schema invalidation.docs/superpowers/plans/and refresh validation notes.Validation
TMPDIR=/tmp PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=src python3 -m pytest -q->110 passed, 1 skippedPYTHONDONTWRITEBYTECODE=1 PYTHONPATH=src python3 scripts/validate_skill.py --run-evals-> OK,19 test files, 6 eval cases, 9 trigger cases, 4 model benchmark casesTMPDIR=/tmp PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=src python3 -m pytest tests/test_distribution_smoke.py -q->1 skippedunless artifact smoke is explicitly enabled25839910412-> success, including Python 3.10/3.11/3.12 tests and wheel/sdist distribution smokepython3 -m build --version-> unavailable locally:No module named build; CI installsbuildfor distribution smoke