Skip to content

Fix Tick crash (fixes #73)#97

Open
def- wants to merge 15 commits into
ddnet:masterfrom
def-:pr-fix-tick-crash
Open

Fix Tick crash (fixes #73)#97
def- wants to merge 15 commits into
ddnet:masterfrom
def-:pr-fix-tick-crash

Conversation

@def-

@def- def- commented May 5, 2020

Copy link
Copy Markdown
Member

No description provided.

@fokkonaut

Copy link
Copy Markdown

why isnt this needed in ddnet6?

@def-

def- commented May 5, 2020

Copy link
Copy Markdown
Member Author

Not sure, have never seen this crash on DDNet6. Maybe we don't delete the player on SendMsg already, but do so later?

@fokkonaut

fokkonaut commented May 5, 2020

Copy link
Copy Markdown

Could you check it and apply the ddnet6 version? As I said in the issue, I just took the initial commit I think

EDIT: i dont understand where the player gets removed?

@def-

def- commented May 5, 2020

Copy link
Copy Markdown
Member Author

Hm, I also can't find a location where the player would get deleted. I'm just fishing in the dark here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants