Skip to content

feat: add loading state and prevent duplicate submissions #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ty-kim7 merged 1 commit into from
Oct 19, 2025
Merged

feat: add loading state and prevent duplicate submissions #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions platform/CTFd/themes/ddps/assets/js/sql_challenge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,13 @@ function resetSQLEditor() {

// Execute SQL Query (test mode - checks correctness but doesn't record submission)
async function executeSQLQuery() {
const testButton = document.getElementById('challenge-execute');

// Prevent duplicate clicks
if (testButton.disabled) {
return;
}

const challengeId = document.getElementById('challenge-id').value;
const submission = sqlEditor ? sqlEditor.getValue() : document.getElementById('challenge-input').value;
// Get user information from CTFd object
Expand All @@ -284,6 +291,11 @@ async function executeSQLQuery() {
return;
}

// Disable button and show loading state
testButton.disabled = true;
const originalHTML = testButton.innerHTML;
testButton.innerHTML = '<i class="fas fa-spinner fa-spin me-1"></i> Testing...';

try {
const requestBody = {
challenge_id: parseInt(challengeId),
Expand Down Expand Up @@ -360,11 +372,22 @@ async function executeSQLQuery() {
console.error('Error details:', error.message, error.stack);
showErrorToast('Error executing query. Please try again.');
}
} finally {
// Re-enable button and restore original text
testButton.disabled = false;
testButton.innerHTML = originalHTML;
}
}

// Submit SQL Challenge
async function submitSQLChallenge() {
const submitButton = document.getElementById('challenge-submit');

// Prevent duplicate clicks
if (submitButton.disabled) {
return;
}

const challengeId = document.getElementById('challenge-id').value;
const submission = sqlEditor ? sqlEditor.getValue() : document.getElementById('challenge-input').value;
// Get user information from CTFd object
Expand All @@ -376,6 +399,11 @@ async function submitSQLChallenge() {
return;
}

// Disable button and show loading state
submitButton.disabled = true;
const originalHTML = submitButton.innerHTML;
submitButton.innerHTML = '<i class="fas fa-spinner fa-spin me-1"></i> Submitting...';

// Check deadline before submitting
const deadlineElement = document.getElementById('deadline-time');
if (deadlineElement) {
Expand All @@ -393,6 +421,9 @@ async function submitSQLChallenge() {
}
};
displayResult(deadlineResult, false);
// Re-enable button
submitButton.disabled = false;
submitButton.innerHTML = originalHTML;
return;
}
}
Expand Down Expand Up @@ -459,6 +490,10 @@ async function submitSQLChallenge() {
console.error('Error submitting challenge:', error);
showErrorToast('Error submitting challenge. Please try again.');
}
} finally {
// Re-enable button and restore original text
submitButton.disabled = false;
submitButton.innerHTML = originalHTML;
}
}

Expand Down
Loading