docs(claude): codify conventions/tests per-framework isolation rules - #121
Merged
Merged
Conversation
Generalizes the pattern established while reducing per-framework coupling in internal/conventions/ and tests/ (#119) into a standing convention, so future framework additions follow it by default instead of re-discovering it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codifies into
CLAUDE.mdthe two conventions established in #119/#120 (reducing per-framework coupling ininternal/conventions/andtests/), so future sessions/contributors follow them by default instead of re-discovering the same anti-patterns:internal/conventions/should only hold constants genuinely used by ≥2 packages; single-consumer constants belong in that framework's own package.tests/<subject>_<framework>_test.go, not scattered into shared grab-bag files; genuinely cross-framework tests stay table-driven with framework names only in test data.No code changes.
Test plan