-
Notifications
You must be signed in to change notification settings - Fork 9
-> Prod #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
-> Prod #259
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a8ef407
fix current version (#252)
ariksfaradi ce13664
Merge branch 'prod' into main
dor-eitan c66ba35
abort stream connection when create chat failed (#251)
netanelben-hamo 8648d91
upgrade sdk version (#255)
netanelben-hamo 9301533
Merge branch 'prod' into main
netanelben-hamo 5d1d66c
Feature/livekit streaming backend metrics (#257)
osimhi213 717af57
Chore/session v2 readiness latency (#258)
osimhi213 a7279d6
Feature/microphone stream (#254)
ariksfaradi f7b0b90
Update agent manager options to make 'mode' optional with a default v…
ReutAtias3 e52b158
Merge branch 'prod' of https://github.com/de-id/agents-sdk into bugfi…
osimhi213 b00b452
Merge pull request #262 from de-id/bugfix/sync-prod-to-main
osimhi213 bf2ee50
bump (#263)
ariksfaradi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Microphone state not reset on disconnect breaks reconnection
Medium Severity
The
disconnectcallback resetsagentManager,srcObject,connectionState, andmessagesbut does not resetisMicrophonePublishedtofalse. When a user disconnects and later reconnects,isMicrophonePublishedremainstruefrom the previous session. This causes the auto-publish effect inapp.tsx(which checks!isMicrophonePublished) to skip publishing the microphone stream, breaking automatic microphone activation on reconnection.