fix: file handle leak, viewBox null check, and stale op_id bug#4
Open
fix: file handle leak, viewBox null check, and stale op_id bug#4
Conversation
…eps_d3 - c_story.py: use context manager for svg.write() to prevent file handle leak - c_story.py: add null check for missing viewBox attribute in adjust_icon_svgs - debrief_svc.py: use operation.id instead of stale op_id loop variable in build_steps_d3 second loop (was referencing last value from first loop)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of mitre/debrief PR mitre#81 for Copilot review