fix: HUD base branch detection matching raw commit hashes#156
Merged
Conversation
detectBaseBranch layer 2 (HEAD reflog) was matching raw commit hashes from old detached-HEAD checkouts, causing bogus ahead/behind counts (e.g. 50↑ on main). Now skips hex-only strings. Also: when on main/master, compare against origin/main instead of main vs main (which is always 0/0). Docs: add skill shadowing section and HUD options to README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detectBaseBranchlayer 2 (HEAD reflog) matching raw commit hashes from old detached-HEAD checkouts, causing bogus ahead/behind counts (e.g.50↑ 1↓when on main)main/master, compare againstorigin/maininstead ofmainvsmain(always 0/0)Test plan
npm test— 364/364 passingmainbranch, HUD should show 0↑ 0↓ (or omit ahead/behind entirely)devflow init --hud-only