fix(ambient): ensure skill tool invocations happen before text output#158
Merged
fix(ambient): ensure skill tool invocations happen before text output#158
Conversation
Skills were not loading despite correct classification because the model would print "Loading: X, Y" then skip the actual Skill tool calls. Fix by reversing the instruction order: invoke Skill tools first, then state classification text. This prevents the model from generating prose that overrides the tool-call requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skill()tool calls — generating prose overrides the tool-call requirementChanges
shared/skills/ambient-router/SKILL.md— IMPORTANT block and Step 4 now require tool calls first, classification text afterscripts/hooks/ambient-prompt— preamble reinforces "FIRST tool calls MUST be Skill tool invocations"tests/integration/helpers.ts— sync preamble stringtests/ambient.test.ts— sync drift detection expected valueCHANGELOG.md— add fix to [Unreleased]Test plan
npm run build)npm test)