fix(hud): version badge cache ignores post-install version changes#159
Merged
fix(hud): version badge cache ignores post-install version changes#159
Conversation
Cache now stores only npm `latest` version. Installed version is always read live from manifest.json, so upgrading between cache refreshes no longer shows a stale upgrade notice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
currentandlatestversions with 24h TTLcurrentcaused the upgrade notice to persistlatest(npm registry result); installed version is always read live frommanifest.jsonTest plan
npm run buildpassesnpm test— all 362 tests passcurrent: 1.8.1, latest: 1.8.2while manifest says1.8.2→ badge should NOT appear