create new console with no new window if in win32#293
Open
Pandaaaa906 wants to merge 1 commit intodeanmalmgren:masterfrom
Open
create new console with no new window if in win32#293Pandaaaa906 wants to merge 1 commit intodeanmalmgren:masterfrom
Pandaaaa906 wants to merge 1 commit intodeanmalmgren:masterfrom
Conversation
|
Hi. I already submitted PR #180 that should fix this. One difference I see with your changes is that you set wShowWindow to SW_HIDE. I think this is not necessary since wShowWindow is set to 0 by default, which is the SW_HIDE value. See the subprocess doc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.