Restart fail2ban using systemd condrestart#120
Open
WilliamDEdwards wants to merge 1 commit intodebops:masterfrom
Open
Restart fail2ban using systemd condrestart#120WilliamDEdwards wants to merge 1 commit intodebops:masterfrom
WilliamDEdwards wants to merge 1 commit intodebops:masterfrom
Conversation
The previous code does two things:
1. Restart fail2ban ONLY if it's running with `fail2ban-client ping`
2. Re-add the fail2ban chain that was removed due to the ferm restart using `fail2ban-client`
However, using `fail2ban-client reload` does not re-add the `f2b-*` chains for me. MRE:
```
~# iptables -nvL | grep f2b
15 1124 f2b-sshd tcp -- * * 0.0.0.0/0 0.0.0.0/0 multiport dports 22
Chain f2b-sshd (1 references)
~# systemctl start ferm
~# iptables -nvL | grep f2b
~# fail2ban-client reload
OK
~# iptables -nvL | grep f2b
```
Restarting the fail2ban service does re-add these chains:
```
~# systemctl restart fail2ban
~# iptables -nvL | grep f2b
3 236 f2b-sshd tcp -- * * 0.0.0.0/0 0.0.0.0/0 multiport dports 22
Chain f2b-sshd (1 references)
```
Aside from this, the current `fail2ban-client ping` logic can be simplified by using systemd `condrestart`, which restarts the service only when it's running. This does mean that this commit assumes fail2ban runs as a systemd service.
I do not use your project, so I am not interested in maintaining or updating this PR. In case losing support for non-systemd systems is unacceptable, feel free to close it.
WilliamDEdwards
force-pushed
the
fix/fail2ban-restart-ferm
branch
from
3f32c9f to
c849c66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code does two things:
fail2ban-client pingfail2ban-clientHowever, using
fail2ban-client reloaddoes not re-add thef2b-*chains for me. MRE:Restarting the fail2ban service does re-add these chains:
Aside from this, the current
fail2ban-client pinglogic can be simplified by using systemdcondrestart, which restarts the service only when it's running. This does mean that this commit assumes fail2ban runs as a systemd service.I do not use your project, so I am not interested in maintaining or updating this PR. In case losing support for non-systemd systems is unacceptable, feel free to close it.