-
Notifications
You must be signed in to change notification settings - Fork 38
feat(tasks): Cmd+Option+Left/Right to cycle task tabs #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wise-toddler
wants to merge
9
commits into
debuglebowski:main
Choose a base branch
from
wise-toddler:fix/task-tab-shortcuts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bd38ea6
feat(tasks): add Cmd+Option+Left/Right and Cmd+1..9 to switch task ta…
wise-toddler 420aa87
fix(transport): add missing resolve-task route stub
wise-toddler 05be66f
fix(app): add missing ws and @trpc/server deps for host-capability-se…
wise-toddler b31c966
fix(shortcuts): suppress task-tab cycle inside text inputs
wise-toddler a4d3b95
test(tasks): cover task-tab keyboard shortcuts (#98)
wise-toddler 5be7430
refactor(shortcuts): address consensus review feedback for task tab s…
wise-toddler b6bf5ae
fix(shortcuts): guard last-task-tab handler against text inputs (#98)
wise-toddler 4ebf5bd
revert(shortcuts): drop Cmd+9 = last-task-tab special case (#98)
wise-toddler cd0f300
revert(shortcuts): drop Cmd+1..9 changes; arrow cycle only (#98)
wise-toddler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/shared/transport/src/server/http/rest-api/sessions/resolve-task.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import type { Express } from 'express' | ||
| import type { RestApiDeps } from '../types' | ||
|
|
||
| // Stub: session → bound task resolution for the slay CLI. Returns 501 until wired. | ||
| export function registerResolveSessionTaskRoute(app: Express, _deps: RestApiDeps): void { | ||
| app.get('/api/sessions/:id/task', (_req, res) => { | ||
| res.status(501).json({ error: 'not implemented' }) | ||
| }) | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next-task-tabandprev-task-tabare registered as customizable shortcuts, but this call reads them through the localgetKeys()helper that treats anulloverride as missing and falls back to the default key. When a user disables Cmd+Option+Right or Cmd+Option+Left in shortcut settings, the handler is still bound to the default and can still switch task tabs while the user expected it to be unbound. Please make this path preserve explicitnulloverrides instead of falling back to the default.Prompt To Fix With AI