fix: witness list changes must be witnessed by the prior list (#6)#7
Merged
Conversation
Per spec §3.7.5 a replacement `witness` list only becomes active after the entry that introduces it is published, so that entry must be witnessed by the list in effect before it. WizardWitnessProofs and WitnessValidator were using the new (merged) list instead, so reducing a list (e.g. two witnesses down to one) produced and required only a single proof. Both now use the prior active list whenever witnessing was already active, with the new list applying only on first activation, matching the Rust reference output for vectors/witness-update. Add WitnessValidator regression tests for the witness-update reduction scenario, update the CHANGELOG [Unreleased] section, and document the changelog/commit workflow in docs/AGENTS.md.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
============================================
+ Coverage 82.83% 82.88% +0.04%
+ Complexity 606 605 -1
============================================
Files 53 53
Lines 1730 1729 -1
Branches 304 303 -1
============================================
Hits 1433 1433
Misses 128 128
+ Partials 169 168 -1
🚀 New features to boost your workflow:
|
Bump parent + module poms from 0.3.0-SNAPSHOT to 0.3.1-SNAPSHOT and update README Maven/Gradle coordinates to 0.3.1. Promote the witness-list-timing fix (issue #6) from [Unreleased] to a new "## [0.3.1] - 2026-06-09" CHANGELOG entry and add the compare links.
|
swcurran
approved these changes
Jun 9, 2026
swcurran
left a comment
swcurran
left a comment
Collaborator
There was a problem hiding this comment.
LGTM -- ran the test-suite on the change and confirmed it worked after a change to the test-suite implementation. Will push an update to the test suite after merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per spec §3.7.5 a replacement
witnesslist only becomes active after the entry that introduces it is published, so that entry must be witnessed by the list in effect before it. WizardWitnessProofs and WitnessValidator were using the new (merged) list instead, so reducing a list (e.g. two witnesses down to one) produced and required only a single proof. Both now use the prior active list whenever witnessing was already active, with the new list applying only on first activation, matching the Rust reference output for vectors/witness-update.Add WitnessValidator regression tests for the witness-update reduction scenario, update the CHANGELOG [Unreleased] section, and document the changelog/commit workflow in docs/AGENTS.md.
Fixes #6