Merged
Conversation
- Updated `coerceNumericField` to accept numeric strings for both integer and float fields, normalizing them to numbers. - Added tests to ensure that numeric strings are correctly parsed and coerced in the `flattenRequestSchema` function. - Improved type handling for path parameters, allowing for more flexible input in request validation.
- Changed the TypeScript types configuration from "bun-types" to "bun" for improved compatibility and clarity in the project setup.
- Updated the `createToolFromOperation` function to return a structured response when the result data is null, undefined, or not an object, ensuring consistent handling of various data types.
- Enhanced the error handling in the `createToolFromOperation` function to provide clearer error messages. The error message is now derived from the error object directly, ensuring that both string and object errors are handled appropriately.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🚀 Preview Deployments Ready!Your changes have been deployed to preview environments: 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Improve VTEX tool adapter by normalizing operation results and making error messages clearer. Prevents crashes when SDK returns null, undefined, or primitive values and provides consistent response shapes.
Bug Fixes
Migration
Written for commit 28fc4ec. Summary will update on new commits.