Fix MEX compilation on macOS Apple Silicon by forcing classic linker (-ld_classic)#14
Open
MasWag wants to merge 1 commit intodecyphir:masterfrom
Open
Fix MEX compilation on macOS Apple Silicon by forcing classic linker (-ld_classic)#14MasWag wants to merge 1 commit intodecyphir:masterfrom
MasWag wants to merge 1 commit intodecyphir:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes MEX compilation failures on macOS Apple Silicon (
maca64) caused by recent Apple/Xcode linker behavior.On affected systems, MEX builds fail with undefined MATLAB adapter symbols such as:
_mexCreateMexFunction_mexDestroyMexFunction_mexFunctionAdapterThe workaround is to force the classic Apple linker by appending:
'LDFLAGS=\$LDFLAGS -ld_classic'to
mexinvocations on macOS arm64 only.What this PR changes
Adds a platform-conditional workaround (
ismac && strcmp(computer('arch'),'maca64')) to MEX build paths, including:InstallBreach.m@STL_Formula/private/src/robusthom/CompileRobusthom.mOnline/m_src/compile_stl_mex.mand related MEX build scripts used during installation/build.
Notes
_mexCreateMexFunctionundefined) #13, this is a workaround for recent Apple linker changes on macOS arm64.-ld_classicbeing deprecated is expected.Closes #13