Skip to content

did a check on publicPath with a default#5

Open
thescientist13 wants to merge 1 commit intodeecewan:masterfrom
thescientist13:bug/issue-4-public-path-undefined
Open

did a check on publicPath with a default#5
thescientist13 wants to merge 1 commit intodeecewan:masterfrom
thescientist13:bug/issue-4-public-path-undefined

Conversation

@thescientist13
Copy link
Copy Markdown

@thescientist13 thescientist13 commented Nov 18, 2017

resolves #4 by fixing an undefined error

not sure if this the best solution, but works for me locally in Chrome
screen shot 2017-11-17 at 11 08 14 pm

screen shot 2017-11-17 at 11 08 21 pm

@thescientist13
Copy link
Copy Markdown
Author

As reported in #4 , I was trying to use images from FaviconsWebpackPlugin, but not seeing that show up in the manifest tab above ^. Related to #2 , or should I open a new issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'length' of undefined

1 participant