Update get_room_location_id indexes to allow for generation#6
Closed
deefdragon wants to merge 1 commit intomainfrom
Closed
Update get_room_location_id indexes to allow for generation#6deefdragon wants to merge 1 commit intomainfrom
deefdragon wants to merge 1 commit intomainfrom
Conversation
Owner
Author
|
issues addressed in PR #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up several ID issues with the locations to allow for test generations and some debugging of the initial implementation.
It also adds the functions necessary to allow yaml-less universal tracker support in the main world file.
Draft to account for formatter being run on code making exact diff hard to parse. Will make actual PR when appropriate.