Started working on dare logic; Added fill_slot_data#9
Merged
BatmenzDW merged 14 commits intodeefdragon:mainfrom Mar 12, 2026
Merged
Started working on dare logic; Added fill_slot_data#9BatmenzDW merged 14 commits intodeefdragon:mainfrom
BatmenzDW merged 14 commits intodeefdragon:mainfrom
Conversation
Collaborator
Author
|
Just going to merge this since you said you're busy |
Owner
|
Just took a quick look and it looks fine assuming it passes testing. TY. Also, this made me realize why I was confused why it wasn't adding the slot data. The My PR that added the fill_slot_data work was the one that also had the ID fixes, which I closed because i thought there was nothing necessary left to do in it since you made a PR fixing that. Goes to show the importance of separation of concerns in PRs I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.