Skip to content

fix: converted non-interactive avatar div to accessible semantic button (#45) #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deekshithgowda85 merged 2 commits into from
May 30, 2026
Merged

fix: converted non-interactive avatar div to accessible semantic button (#45) #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
625632d
fix: updated raw avatar div to accessible semantic button layout #45
prakshithamalla-art May 30, 2026
3df6b46
Merge branch 'prod' into fix-avatar-accessibility-45
prakshithamalla-art May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions components/console/account-page-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ export function AccountPageClient({ user, hasGithubConnection }: { user: UserPro
const handleDeleteAccount = async () => {
if (deleteInput !== "delete my account") return;

// Direct user-intent safety gate validation matching Issue instructions
const doubleConfirm = window.confirm(
"CRITICAL WARNING: Are you completely sure you want to delete your account? This will instantly purge all sandboxes, deployments, security logs, and custom configuration secrets permanently."
);
Expand Down Expand Up @@ -124,18 +123,23 @@ export function AccountPageClient({ user, hasGithubConnection }: { user: UserPro
</div>
)}

{/* Fixed Avatar Element: Semantic button wrapper with keyboard focus accessibility */}
<div className="flex items-center gap-4">
<div className="group relative cursor-pointer">
<button
type="button"
aria-label="Change account avatar"
className="group relative focus:outline-none focus:ring-2 focus:ring-gray-900 dark:focus:ring-white rounded-full transition-shadow"
>
<div className="flex h-16 w-16 select-none items-center justify-center rounded-full bg-gray-900 text-2xl font-bold text-white dark:bg-white dark:text-gray-900">
{user?.email?.[0]?.toUpperCase() ?? "U"}
</div>
<div className="absolute inset-0 flex items-center justify-center rounded-full bg-black/40 opacity-0 transition-opacity group-hover:opacity-100">
<div className="absolute inset-0 flex items-center justify-center rounded-full bg-black/40 opacity-0 transition-opacity group-hover:opacity-100 group-focus:opacity-100">
<Camera className="h-5 w-5 text-white" />
</div>
</div>
</button>
<div>
<p className="text-sm font-medium text-gray-800 dark:text-zinc-200">Account Avatar</p>
<p className="text-xs text-gray-500 dark:text-zinc-500">Use a generic avatar for privacy.</p>
<p className="text-xs text-gray-500 dark:text-zinc-500">Click avatar badge to update graphics controls.</p>
</div>
</div>

Expand Down
Loading