Expose raw logit weights to the API if request_logits=true#7
Open
pathorn wants to merge 1 commit intodeepinfra:mainfrom
Open
Expose raw logit weights to the API if request_logits=true#7pathorn wants to merge 1 commit intodeepinfra:mainfrom
pathorn wants to merge 1 commit intodeepinfra:mainfrom
Conversation
pathorn
force-pushed
the
logit_weights
branch
from
bb4a084 to
2ca7361
Compare
NikolaBorisov
left a comment
NikolaBorisov
left a comment
There was a problem hiding this comment.
I was thinking we could have options to return top 100 or 1000 tokens in addition to all. Right now returning 32000 * 32 is 1MB
Comment on lines
+188
to
+189
| /// Logit tokens | ||
| optional string logit_tokens = 3; |
There was a problem hiding this comment.
here you have string, and bytes above. I think you want bytes?
| if req.0.parameters.return_full_text.unwrap_or(false) { | ||
| add_prompt = Some(req.0.inputs.clone()); | ||
| } | ||
| // let return_logits = req.0.parameters.return_logits; |
| text: generation.token_text, | ||
| logprob: generation.token_logprob, | ||
| special: generation.token_is_special, | ||
| logits: if let Some(binfloats) = generation.logit_binary { Some(general_purpose::URL_SAFE.encode(binfloats)) } else { None }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new input boolean parameter
return_logits. If true, each Generation will contain the base64 of the binary float32 array of logit weights inside the Token's details.I have tested performance and this extra output data does not add any measurable performance overhead.
It would be useful to have a test application on top of this API to demonstrate its usefulness.