fix(dprc): count local atoms in qm-only maps#5843
Open
njzjz-bot wants to merge 2 commits into
Open
Conversation
Count local QM atoms independently of the MM-fragment loop so single-fragment pairwise maps report consistent metadata and cannot overrun the forward map. Cover direct map construction and mixed-frame TensorFlow padding. Coding-Agent: Codex Codex-Version: codex-cli 0.144.4 Model: gpt-5.6-sol Reasoning-Effort: xhigh
for more information, see https://pre-commit.ci
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5843 +/- ##
==========================================
- Coverage 78.58% 78.32% -0.26%
==========================================
Files 1050 1050
Lines 120637 120644 +7
Branches 4356 4355 -1
==========================================
- Hits 94801 94500 -301
- Misses 24278 24583 +305
- Partials 1558 1561 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-1placeholdersWhy existing tests missed the bug
nlocinitialization with the real local-QM count.-1placeholders, leaving the one-fragment branch uncovered.Validation
cmake --build source/build --target runUnitTests_lib -j2source/build/lib/tests/runUnitTests_lib --gtest_filter='TestGroupAtoms.*:TestPairwiseMap.*'(3 passed)pytest source/tests/tf/test_pairwise_dprc.py::TestPairwiseOP::test_op_single_fragment_with_placeholders source/tests/tf/test_pairwise_dprc.py::TestPairwiseOP::test_op_single_frame -q(2 passed)ruff format .ruff check .Fixes #5649
Coding agent: Codex
Codex version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning effort: xhigh
Summary by CodeRabbit
Bug Fixes
Tests