This repository was archived by the owner on Jul 29, 2026. It is now read-only.
Conversation
anakin87
changed the title
anakin87
commented
Apr 17, 2026
| def test_role_based_memories(self, memory_store): | ||
| store, user_id = memory_store | ||
| unique_agent_id = _get_unique_user_id() | ||
| messages = [ |
Member
Author
There was a problem hiding this comment.
@sjrl could you review this change in particular?
Contributor
There was a problem hiding this comment.
Hard for me to review since I don't fully understand Mem0. It looks reasonable to me in the sense that if that's what Mem0 requires then that's fine.
I don't think I really know of a use case for this. I.e. I don't know when I'd want to search for these two sets separately.
Member
Author
Member
Author
|
I reached out to Amna. She'll let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
async_modeparameter (removed in underlying API)How did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.