Skip to content

fix(controller): drop invalid --enable-metrics flag from vLLM runtime #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Defilan merged 1 commit into from
Jul 9, 2026
+10 −6
Merged

fix(controller): drop invalid --enable-metrics flag from vLLM runtime #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions internal/controller/inferenceservice_deployment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3662,11 +3662,12 @@ var _ = Describe("RuntimeBackend interface", func() {
Expect(args).NotTo(ContainElement("--model"))
Expect(args).To(ContainElements("--host", "::"))
Expect(args).To(ContainElements("--port", "8000"))
// --enable-metrics is always set so vLLM pods expose /metrics for
// PodMonitor scraping (#409).
Expect(args).To(ContainElement("--enable-metrics"))
// Six elements: <model> --host :: --port 8000 --enable-metrics.
Expect(args).To(HaveLen(6))
// vLLM has no --enable-metrics flag; it always exposes /metrics.
// Emitting the flag makes vLLM reject the command and the pod never
// starts (#1030), so it must never appear.
Expect(args).NotTo(ContainElement("--enable-metrics"))
// Five elements: <model> --host :: --port 8000.
Expect(args).To(HaveLen(5))
})

It("should append extraArgs after typed flags", func() {
Expand Down
5 changes: 4 additions & 1 deletion internal/controller/runtime_vllm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,11 @@ func (b *VLLMBackend) BuildArgs(isvc *inferencev1alpha1.InferenceService, model
// which are appended last so the user flag wins.
"--host", "::",
"--port", fmt.Sprintf("%d", port),
"--enable-metrics",
}
// NOTE: vLLM has no --enable-metrics flag. Its OpenAI server always exposes
// Prometheus metrics at /metrics, so there is nothing to enable; passing the
// flag makes vLLM's argument parser reject the whole command and the pod
// never starts (#1030). The PodMonitor scrapes /metrics unconditionally.

var err error

Expand Down
Loading