Fix implicit nullable parameter deprecations for PHP 8.4 (3.x)#53
Open
nige-one wants to merge 2 commits into
Open
Fix implicit nullable parameter deprecations for PHP 8.4 (3.x)#53nige-one wants to merge 2 commits into
nige-one wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same class of fix as #52, but against the
3.xrelease line (tags 3.0.0–3.1.4), which is what composer installs.PHP 8.4 deprecates implicitly nullable parameters (typed parameters defaulting to
nullwithout an explicit?). In Magento developer mode the deprecation is escalated to an exception byMagento\Framework\App\ErrorHandler, breakingsetup:di:compile— this is the failure reported in #51 (TransportBuilder::__construct()).Fixed parameters:
Model/GenericReportCollection.php:$resourceConnectionModel/Mail/Template/TransportBuilder.php:$messageFactory,$emailMessageInterfaceFactory,$mimeMessageInterfaceFactory,$mimePartInterfaceFactory,$addressConverter(now matching the explicit nullable types of the coreMagento\Framework\Mail\Template\TransportBuilderparent)No behavior change; compatible with PHP 7.1+.
Fixes #51