fix(conformance): discard SelectNReq uses Resolution context#215
fix(conformance): discard SelectNReq uses Resolution context#215
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Wire shows discard prompts use the same context/listType/optionContext as legend-rule — only sourceId differs. Fix the non-legend-rule branch to match: - context: Discard → Resolution - listType: Static → Dynamic - optionContext: (unset) → Resolution Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CI Report — GateTests: 816/816 passed (189 skipped) Coverage: 10.5% (615/5852 lines)
Slow tests (>3s): 1
|
|
@claude please review this ralph PR |
|
Claude finished @delebedev's task in 42s —— View job PR Review
Overall: LGTM with one minor doc nit. The fix is correct, minimal, and well-evidenced. What changed
The diff is clean and the One nit: stale KDoc
* Context/listType vary by prompt type:
* - `legend_rule`: context=Resolution, listType=Dynamic
* - `choose_cards` (discard): context=Discard, listType=StaticThis should be updated to reflect that both paths use Test coverageThe new test at CI is green: 996 tests, +1 new, 0 failures. |
Closes #175
Summary
SelectNReq: context (Discard→Resolution), listType (Static→Dynamic), optionContext (unset→Resolution)Test plan
discard SelectNReq uses Resolution context and Dynamic listType— verifies all 3 fixed fields + existing correct fieldsLegendRuleTest— still passes (shared builder path)BundleBuilderTest— 14/14 pass🤖 Generated with Claude Code