Feature branch sync - pub/q2_upgrade to staging#4756
Merged
Conversation
… add file path in error (#4753) Fixes OMN01D-2552: Input validation missing for PXE mapping ADMIN_IP and network_spec additional_subnets consistency checks. Issues fixed: 1. Remove duplicate subnet consistency check from high_availability_validation.py that caused the same error to appear against both provision_config.yml and high_availability_config.yml. The check now runs only in provision_validation. 2. Include the PXE mapping file path in the error_key so the rendered message shows which file contains the misconfigured ADMIN_IP: [pxe_mapping_file_path]: ADMIN_IP subnet consistency Files changed: - high_availability_validation.py: removed validate_all_host_ips_same_subnet_as_vip call and unused import - provision_validation.py: prepend pxe_mapping_file_path to error_key - test_additional_subnets_validation.py: assert file path present in error_key Signed-off-by: Sujit Jadhav <sujit.jadhav@dell.com>
* fix BuildStream rollback source directory restoration - Remove existing 2.2 source directory completely before restoring from backup - Remove failed_when: false from source directory restoration task to catch errors Signed-off-by: venu <236371043+Venu-p1@users.noreply.github.com> * fix BuildStream rollback watcher service restart and validation Signed-off-by: venu <236371043+Venu-p1@users.noreply.github.com> * refactor BuildStream rollback watcher service validation to use systemd_service module Signed-off-by: venu <236371043+Venu-p1@users.noreply.github.com> --------- Signed-off-by: venu <236371043+Venu-p1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature branch sync - pub/q2_upgrade to staging