fix(s3): guard ETag and version-id reads against missing headers#105
Merged
mikehorgan-dell merged 1 commit intomainfrom May 5, 2026
Merged
fix(s3): guard ETag and version-id reads against missing headers#105mikehorgan-dell merged 1 commit intomainfrom
mikehorgan-dell merged 1 commit intomainfrom
Conversation
handleResponseHeaders unconditionally recorded the part ETag into the parent MPU task's context map (a ConcurrentHashMap, which rejects null values). On any non-2xx part-PUT response the ETag header is absent, producing a NullPointerException that surfaced as misleading "Premature channel closure" warnings and obscured the underlying server failure. The versioning branch had a parallel issue: a missing x-amz-version-id header caused the literal string "null" to be appended to the item name, compounding "~null~null~..." across retries. Both branches now skip mutation when the header is absent. Adds a regression test covering each case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S3ResponseHandler.handleResponseHeadersran unconditionally on every response. Two header reads inside it weren't null-safe:ETag. The handler then calledmpuTask.put(partNum, null)on aConcurrentHashMap, which throws NPE. The exception surfaced as misleadingPremature channel closurewarnings and masked the actual upstream 4xx/5xx failure."null"was appended to the item name, compounding~null~null~...across retries.Both branches now early-out when the header is absent. Behavior is unchanged on success responses.