Skip to content

Comments

[build] Add tex-gyre build-dep#3373

Open
pieleric wants to merge 1 commit intodelmic:masterfrom
pieleric:build-add-tex-gyre-build-dep
Open

[build] Add tex-gyre build-dep#3373
pieleric wants to merge 1 commit intodelmic:masterfrom
pieleric:build-add-tex-gyre-build-dep

Conversation

@pieleric
Copy link
Member

The texlive-fonts-recommended has tex-gyre as a recommended
dependency. This dependency is need to build the documentation.
However, the Ubuntu build system doesn't install the recommended
dependencies (only the required ones), contrarily to the standard
behaviour of apt. So it wasn't installed, and the build failed.

=> Add this dependency explicitly.

Also adjust the CI build instruction to behave in the same way.

The texlive-fonts-recommended has tex-gyre as a *recommended*
dependency. This dependency is need to build the documentation.
However, the Ubuntu build system doesn't install the recommended
dependencies (only the required ones), contrarily to the standard
behaviour of apt. So it wasn't installed, and the build failed.

=> Add this dependency explicitly.

Also adjust the CI build instruction to behave in the same way.
Copilot AI review requested due to automatic review settings February 19, 2026 17:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a documentation build failure by explicitly adding the tex-gyre package as a build dependency. The issue occurred because Ubuntu's build system does not install recommended dependencies by default, unlike standard apt behavior, and tex-gyre is only a recommended (not required) dependency of texlive-fonts-recommended.

Changes:

  • Added tex-gyre as an explicit build dependency in debian/control
  • Updated the GitHub Actions workflow to use --no-install-recommends flag to match Ubuntu build system behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
debian/control Added tex-gyre as an explicit build dependency after texlive-fonts-recommended to ensure documentation can be built successfully
.github/workflows/build_debian.yml Added --no-install-recommends flag to mk-build-deps command to mirror Ubuntu build system behavior and catch similar issues in CI

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The pull request makes two changes to the Debian build configuration. First, the GitHub Actions build workflow for Debian is updated to invoke mk-build-deps with the --no-install-recommends flag, which prevents automatic installation of recommended packages during dependency resolution. Second, a new build dependency, tex-gyre, is added to the Build-Depends field in debian/control. These changes optimize the build environment by reducing unnecessary package installations while explicitly declaring an additional required dependency.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding tex-gyre as an explicit build dependency to fix documentation build failures.
Description check ✅ Passed The description clearly explains why tex-gyre is needed, the root cause of the build failure, and how the changes address it across both the control file and CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants