Conversation
The texlive-fonts-recommended has tex-gyre as a *recommended* dependency. This dependency is need to build the documentation. However, the Ubuntu build system doesn't install the recommended dependencies (only the required ones), contrarily to the standard behaviour of apt. So it wasn't installed, and the build failed. => Add this dependency explicitly. Also adjust the CI build instruction to behave in the same way.
There was a problem hiding this comment.
Pull request overview
This pull request fixes a documentation build failure by explicitly adding the tex-gyre package as a build dependency. The issue occurred because Ubuntu's build system does not install recommended dependencies by default, unlike standard apt behavior, and tex-gyre is only a recommended (not required) dependency of texlive-fonts-recommended.
Changes:
- Added
tex-gyreas an explicit build dependency indebian/control - Updated the GitHub Actions workflow to use
--no-install-recommendsflag to match Ubuntu build system behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| debian/control | Added tex-gyre as an explicit build dependency after texlive-fonts-recommended to ensure documentation can be built successfully |
| .github/workflows/build_debian.yml | Added --no-install-recommends flag to mk-build-deps command to mirror Ubuntu build system behavior and catch similar issues in CI |
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe pull request makes two changes to the Debian build configuration. First, the GitHub Actions build workflow for Debian is updated to invoke mk-build-deps with the 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The texlive-fonts-recommended has tex-gyre as a recommended
dependency. This dependency is need to build the documentation.
However, the Ubuntu build system doesn't install the recommended
dependencies (only the required ones), contrarily to the standard
behaviour of apt. So it wasn't installed, and the build failed.
=> Add this dependency explicitly.
Also adjust the CI build instruction to behave in the same way.