[MSD-359][feature] Renumber FM fiducials in multipoint window#3378
Open
K4rishma wants to merge 1 commit intodelmic:masterfrom
Open
[MSD-359][feature] Renumber FM fiducials in multipoint window#3378K4rishma wants to merge 1 commit intodelmic:masterfrom
K4rishma wants to merge 1 commit intodelmic:masterfrom
Conversation
In multi_point_correlation.py, if there are no FIB fiducials at GUI start, renumber FM fiducials so their indices are contiguous starting from 1. This handles cases where FM fiducials may have gaps (e.g. 1,2,3,6). The function renumber_fm_fiducials_on_start method updates both the `index` and `name` fields of the FM targets in-place and persists the feature file via `update_feature_correlation_target` so the rest of the GUI sees the corrected ordering when it initializes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi_point_correlation.py, if there are no FIB fiducials at GUI start, renumber FM fiducials so their indices are contiguous starting from 1. This handles cases where FM fiducials may have gaps (e.g. 1,2,3,6). The function renumber_fm_fiducials_on_start method updates both the
indexandnamefields of the FM targets in-place and persists the feature file viaupdate_feature_correlation_targetso the rest of the GUI sees the corrected ordering when it initializes.