Skip to content

Fix close position button #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DannyDelott merged 1 commit into from
Mar 21, 2025
Merged

Fix close position button #1832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/hyperdrive-trading/src/ui/portfolio/longs/OpenLongsTable/ManageLongsButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function ManageLongsButton({
<button
className="m-0 flex h-[52px] w-full flex-row items-center justify-start border-b-2 border-b-neutral-content/20 p-0 text-start hover:bg-neutral hover:text-neutral-content"
onClick={() => {
const modalId = `${assetId}`;
const modalId = `${hyperdrive.address}-${assetId}`;
(
document.getElementById(modalId) as HTMLDialogElement
).showModal();
Expand Down
2 changes: 1 addition & 1 deletion apps/hyperdrive-trading/src/ui/portfolio/longs/OpenLongsTable/OpenLongsTableDesktop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export function OpenLongsTableDesktop({
<div className="daisy-card overflow-x-clip rounded-box bg-gray-750 pt-3">
{/* Modal needs to be rendered outside of the table so that dialog can be used. Otherwise react throws a dom nesting error */}
{tableInstance.getRowModel().rows.map(({ original }) => {
const modalId = `${original.assetId}`;
const modalId = `${original.hyperdrive.address}-${original.assetId}`;
return (
<CloseLongModalButton
key={modalId}
Expand Down
2 changes: 1 addition & 1 deletion apps/hyperdrive-trading/src/ui/portfolio/shorts/OpenShortsTable/ManageShortButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function ManageShortButton({
<button
className="m-0 flex h-[52px] w-full flex-row items-center justify-start border-b-2 border-b-neutral-content/20 p-0 text-start hover:bg-neutral hover:text-neutral-content"
onClick={() => {
const modalId = `${assetId}`;
const modalId = `${hyperdrive.address}-${assetId}`;
(
document.getElementById(modalId) as HTMLDialogElement
).showModal();
Expand Down
2 changes: 1 addition & 1 deletion apps/hyperdrive-trading/src/ui/portfolio/shorts/OpenShortsTable/OpenShortsTableDesktop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export function OpenShortsTableDesktop({
<div className="daisy-card overflow-x-clip rounded-box bg-gray-750 pt-3">
{/* Modal needs to be rendered outside of the table so that dialog can be used. Otherwise react throws a dom nesting error */}
{tableInstance.getRowModel().rows.map((row) => {
const modalId = `${row.original.assetId}`;
const modalId = `${row.original.hyperdriveAddress}-${row.original.assetId}`;
return (
<CloseShortModalButton
key={modalId}
Expand Down
Loading