Add Appium smoke tests for top-level menu items#18
Merged
Conversation
Extend MainWindowShellIntegrationTests with low-risk discoverability/enabled coverage for menu items that already carry AutomationProperties.AutomationId but had no Appium test yet: - File > AddFolderSourceMenuItem - View > WorkspacePanelMenuItem - View > PredefinedViewsMenuItem - View > DiagnosticsMenuItem - View > ViewBuilderDialogMenuItem - Query > QueryDialogMenuItem Each test opens the parent menu, asserts the item is displayed and enabled, then closes the menu via Escape without clicking - clicking would toggle dock panels or open dialogs with no automation-id-based close path, which would leave the shared AppFixture session in an inconsistent state between tests. Extracted a private AssertMenuItemIsDiscoverableAndEnabled helper and refactored the existing AddFileSourceMenuItem test to use it. Updated docs/reqstream/ots/appium.yaml and docs/verification/ots/appium.md to keep the Appium-LocateControlsByAutomationId requirement's test list and verification narrative in sync with the six new tests. Validated: dotnet build (0 errors); build.ps1 -IntegrationTest (9/9 passing against a live NovaWindows Appium session); build.ps1 -Test (283 passing). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request expands and refactors the integration test coverage for menu item accessibility in the desktop app. It adds new tests for additional menu items across the File, View, and Query menus, ensuring that each is discoverable and enabled via automation IDs. The test logic is also refactored for better maintainability by introducing a reusable helper method. Documentation is updated to reflect the expanded test coverage.
Test coverage expansion:
AddFolderSourceMenuItem(File menu),WorkspacePanelMenuItem,PredefinedViewsMenuItem,DiagnosticsMenuItem,ViewBuilderDialogMenuItem(View menu), andQueryDialogMenuItem(Query menu).appium.yamlto include these new menu item tests.Test code refactoring:
AssertMenuItemIsDiscoverableAndEnabledto consolidate repeated test logic, improving maintainability and reducing duplication.Documentation updates:
appium.mdto describe the new tests and clarify their behavior, including rationale for not clicking menu items that open dialogs or change persistent UI state.