Implement View-menu toggle behavior with Appium tests#20
Merged
Conversation
- MainWindowView.axaml.cs: ShowOrFocusPanel now toggles open/closed based on Tool.IsOpen (checkbox semantics: checked/open closes on click, unchecked/closed opens+focuses on click). - MainWindowView.axaml: added ToggleType="CheckBox" to the three View-menu items so the checkmark glyph renders alongside their icons. - DiagnosticsToolView.axaml: added AutomationId to the diagnostics ListBox for Appium discoverability. - Added 3 Appium integration tests driving a full close/reopen round trip per panel, verified via panel-content presence/absence rather than UIA checked-state (Avalonia's Win32 automation bridge does not expose the Toggle pattern for MenuItem). - Synced reqstream traceability and verification docs with the final test names and toggle-behavior description. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the View menu panel toggling functionality in the SysML2Workbench desktop application, making the Workspace, Predefined Views, and Diagnostics panels behave as true checkbox-style toggles. It also adds comprehensive integration tests to verify this behavior, improves accessibility for automation testing, and updates documentation to reflect these changes.
Feature and Behavior Improvements
ShowOrFocusPanelmethod inMainWindowView.axaml.csto implement true open/close toggle behavior for panels, so clicking a View menu item closes an open panel or reopens a closed one, matching the menu item's checked state.WorkspacePanelMenuItem,PredefinedViewsMenuItem,DiagnosticsMenuItem) inMainWindowView.axamlto useToggleType="CheckBox", clarifying their toggle semantics in the UI.Accessibility and Automation
AutomationProperties.AutomationId="DiagnosticsListBox"to the Diagnostics panel'sListBoxinDiagnosticsToolView.axamlto enable reliable automation-based lookup.Testing
DesktopApp_ViewMenu_WorkspacePanelMenuItem_TogglesWorkspacePanel,DesktopApp_ViewMenu_PredefinedViewsMenuItem_TogglesPredefinedViewsPanel,DesktopApp_ViewMenu_DiagnosticsMenuItem_TogglesDiagnosticsPanel) and a shared helper method to ensure each View menu item truly toggles its respective panel open/closed, verifying panel presence via automation IDs.appium.yaml).Documentation