Skip to content

Fix limit resetting with lookback when all fetched incidents were dupes #43746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itssapir merged 9 commits into from
Apr 16, 2026
Merged

Fix limit resetting with lookback when all fetched incidents were dupes #43746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
de8b9e0
Fix limit resetting with lookback when all fetched incidents were dupes
itssapir Mar 30, 2026
d2f66ea
Fix logging for 'number of incidents before filtering'
itssapir Mar 30, 2026
6414d69
Add commonserverpython changes directly to SNow file for testing
itssapir Mar 30, 2026
0b969a4
Merge branch 'master' into ServiceNowFixLookback
itssapir Apr 15, 2026
2e72803
Keep only commonserver changes
itssapir Apr 15, 2026
d40ec8a
Fix UTs
itssapir Apr 15, 2026
b35359e
Bump version and RN
itssapir Apr 15, 2026
d66cac3
Doc review fix
itssapir Apr 16, 2026
6ae30b6
Merge branch 'master' into ServiceNowFixLookback
itssapir Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Packs/Base/ReleaseNotes/1_41_72.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Scripts

##### CommonServerPython

Fixed an issue in the *create_updated_last_run_object* function where the fetch limit was incorrectly reset after encountering only duplicate incidents. Causing the system to miss future incidents when lookback was enabled.
2 changes: 1 addition & 1 deletion Packs/Base/Scripts/CommonServerPython/CommonServerPython.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12227,7 +12227,7 @@ def create_updated_last_run_object(last_run, incidents, fetch_limit, look_back,
elif len(incidents) == 0:
new_last_run = {
'time': end_fetch_time,
'limit': fetch_limit,
'limit': new_limit if look_back > 0 else fetch_limit,
}
else:
latest_incident_fetched_time = get_latest_incident_created_time(incidents, created_time_field, date_format,
Expand Down
4 changes: 2 additions & 2 deletions Packs/Base/Scripts/CommonServerPython/CommonServerPython_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9022,7 +9022,7 @@ def test_fetch_with_look_back(self, mocker, params, result_phase1, result_phase2
},
{
'time': '2022-04-06T10:11:00',
'limit': 3,
'limit': 6,
'found_incident_ids': {'1': '', '2': '', '3': ''}
},
{
Expand All @@ -9038,7 +9038,7 @@ def test_fetch_with_look_back(self, mocker, params, result_phase1, result_phase2
},
{
'time': '2022-04-07T10:13:00',
'limit': 3,
'limit': 6,
'found_incident_ids': {'1': '', '2': '', '3': ''}
}
)
Expand Down
2 changes: 1 addition & 1 deletion Packs/Base/pack_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Base",
"description": "The base pack for Cortex XSOAR.",
"support": "xsoar",
"currentVersion": "1.41.71",
"currentVersion": "1.41.72",
"author": "Cortex XSOAR",
"serverMinVersion": "6.0.0",
"url": "https://www.paloaltonetworks.com/cortex",
Expand Down
Loading