removed agentix from event collectors#43748
Conversation
Your contributed AbnormalSecurity pack has been modified on files:Packs/AbnormalSecurity/pack_metadata.json |
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi! Thanks for your work on updating these event collectors and integrations. I've taken a look through the changes and noticed a recurring theme regarding the module categorizations. Across several platforms (like Salesforce, Mimecast, and Shodan), tags such as edr, cloud, and cloud_runtime_security are being applied to tools where they don't quite fit, such as SaaS or email security products. Please review and adjust these modules to ensure they accurately reflect each product's primary function. Thanks again for the contribution!
@Moish-Gilboa, @noydavidi, @BEAdi, @JudahSchwartz, @jbabazadeh, @dantavori please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
| - No tests | ||
| supportedModules: | ||
| - xsiam | ||
| - edr |
There was a problem hiding this comment.
Are you sure edr, cloud, and cloud_runtime_security are appropriate modules for Salesforce? Salesforce is a SaaS platform, not an Endpoint Detection and Response (EDR) or Cloud infrastructure tool.
| tests: | ||
| - No tests (auto formatted) | ||
| supportedModules: | ||
| - cloud |
There was a problem hiding this comment.
Are you sure cloud and cloud_runtime_security are appropriate modules for Monday.com? Monday is a SaaS platform.
| - No tests | ||
| supportedModules: | ||
| - xsiam | ||
| - edr |
There was a problem hiding this comment.
Are you sure edr, cloud, and cloud_runtime_security are appropriate modules for Mimecast? Mimecast is an email security platform, not an EDR or Cloud infrastructure tool.
| - No tests | ||
| supportedModules: | ||
| - xsiam | ||
| - edr |
There was a problem hiding this comment.
Are you sure edr, cloud, and cloud_runtime_security are appropriate modules for Mimecast? Mimecast is an email security platform, not an EDR or Cloud infrastructure tool.
| - No tests (auto formatted) | ||
| supportedModules: | ||
| - xsiam | ||
| - edr |
There was a problem hiding this comment.
Are you sure edr, cloud, and cloud_runtime_security are appropriate modules for Proofpoint Threat Response? Proofpoint is primarily an email security platform.
| fromversion: 5.0.0 | ||
| supportedModules: | ||
| - xsiam | ||
| - edr |
There was a problem hiding this comment.
Are you sure edr, cloud, cloud_runtime_security, and cloud_posture are appropriate modules for Shodan? Shodan is primarily an Attack Surface Management (ASM) tool.
| - No tests (auto formatted) | ||
| supportedModules: | ||
| - xsiam | ||
| - edr |
There was a problem hiding this comment.
Are you sure edr, cloud, and cloud_runtime_security are appropriate modules for ExtraHop Reveal(x)? ExtraHop is primarily a Network Detection and Response (NDR) tool.
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
# Conflicts: # Packs/ManageEngine/ReleaseNotes/1_0_6.md
There was a problem hiding this comment.
No need- it already has only xsiam supportedModules in pack metadata
There was a problem hiding this comment.
here you need to remove the release notes and pack new version
| marketplaces: | ||
| - marketplacev2 | ||
| - platform | ||
| supportedModules: |
There was a problem hiding this comment.
added all supported but agentix as we have platfrom in marketplace but done have supported modules
| fromversion: 8.3.0 | ||
| tests: | ||
| - No tests (auto formatted) | ||
| supportedModules: |
There was a problem hiding this comment.
No need, pack doesn't have agentix
There was a problem hiding this comment.
added all supported but agentix as we have platfrom in marketplace but done have supported modules
| @@ -107,3 +107,5 @@ marketplaces: | |||
| fromversion: 8.4.0 | |||
| tests: | |||
| - No tests (auto formatted) | |||
| supportedModules: | |||
| - xsiam | |||
There was a problem hiding this comment.
no need, pack doesn't have agentix
|
force merge as an effort to remove agentix from all event collectors |
# Conflicts: # Packs/HelloWorld/ReleaseNotes/4_0_2.md
# Conflicts: # Packs/CyberArkEPM/ReleaseNotes/1_1_4.md
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
* removed agentix from event collectors * Bump pack from version iManageThreatManager to 1.0.2. * Bump pack from version Halcyon to 1.0.3. * Bump pack from version HelloWorld to 4.0.2. * Bump pack from version FireEyeHX to 2.4.1. * merge from master * added supported modules * code review * code review * code review * code review * merge from master * merge from master * Bump pack from version ServiceNow to 2.9.5. --------- Co-authored-by: Content Bot <bot@demisto.com>
* removed agentix from event collectors * Bump pack from version iManageThreatManager to 1.0.2. * Bump pack from version Halcyon to 1.0.3. * Bump pack from version HelloWorld to 4.0.2. * Bump pack from version FireEyeHX to 2.4.1. * merge from master * added supported modules * code review * code review * code review * code review * merge from master * merge from master * Bump pack from version ServiceNow to 2.9.5. --------- Co-authored-by: Content Bot <bot@demisto.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: CIAC-15886
Description
removed agentix from event collectors
119 event collectors
4 are fixed here 43744
5 remain unchanged
102 changed in this pr
4 dont have supported modules but marketplace is plaftorm then added in this pr the all of the supported modules but agentix
4 dont have supported modules and marketplace is not plaftorm , this is not part of this pr, @DeanArbel 's team effort here
Must have