Skip to content

removed agentix from event collectors#43748

Merged
jbabazadeh merged 21 commits intomasterfrom
remove-agentix-from-event-collectors-part-2
Apr 13, 2026
Merged

removed agentix from event collectors#43748
jbabazadeh merged 21 commits intomasterfrom
remove-agentix-from-event-collectors-part-2

Conversation

@Shir2611
Copy link
Copy Markdown
Contributor

@Shir2611 Shir2611 commented Mar 30, 2026

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-15886

Description

removed agentix from event collectors

119 event collectors
4 are fixed here 43744
5 remain unchanged
102 changed in this pr
4 dont have supported modules but marketplace is plaftorm then added in this pr the all of the supported modules but agentix
4 dont have supported modules and marketplace is not plaftorm , this is not part of this pr, @DeanArbel 's team effort here

Must have

  • Tests
  • Documentation

@Shir2611 Shir2611 requested review from BEAdi and jbabazadeh March 30, 2026 14:52
@Shir2611 Shir2611 self-assigned this Mar 30, 2026
@Shir2611 Shir2611 added docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines supported-modules-approved ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Mar 30, 2026
@github-actions
Copy link
Copy Markdown

Your contributed AbnormalSecurity pack has been modified on files:

Packs/AbnormalSecurity/pack_metadata.json
Packs/AbnormalSecurity/ReleaseNotes/2_4_4.md
Packs/AbnormalSecurity/Integrations/AbnormalSecurityEventCollector/AbnormalSecurityEventCollector.yml
Please review the changes here

@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Mar 30, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

Coverage

Tests Skipped Failures Errors Time
951 0 💤 0 ❌ 0 🔥 27876427m 17s ⏱️

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your work on updating these event collectors and integrations. I've taken a look through the changes and noticed a recurring theme regarding the module categorizations. Across several platforms (like Salesforce, Mimecast, and Shodan), tags such as edr, cloud, and cloud_runtime_security are being applied to tools where they don't quite fit, such as SaaS or email security products. Please review and adjust these modules to ensure they accurately reflect each product's primary function. Thanks again for the contribution!

@Moish-Gilboa, @noydavidi, @BEAdi, @JudahSchwartz, @jbabazadeh, @dantavori please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

- No tests
supportedModules:
- xsiam
- edr
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure edr, cloud, and cloud_runtime_security are appropriate modules for Salesforce? Salesforce is a SaaS platform, not an Endpoint Detection and Response (EDR) or Cloud infrastructure tool.

tests:
- No tests (auto formatted)
supportedModules:
- cloud
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure cloud and cloud_runtime_security are appropriate modules for Monday.com? Monday is a SaaS platform.

- No tests
supportedModules:
- xsiam
- edr
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure edr, cloud, and cloud_runtime_security are appropriate modules for Mimecast? Mimecast is an email security platform, not an EDR or Cloud infrastructure tool.

- No tests
supportedModules:
- xsiam
- edr
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure edr, cloud, and cloud_runtime_security are appropriate modules for Mimecast? Mimecast is an email security platform, not an EDR or Cloud infrastructure tool.

- No tests (auto formatted)
supportedModules:
- xsiam
- edr
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure edr, cloud, and cloud_runtime_security are appropriate modules for Proofpoint Threat Response? Proofpoint is primarily an email security platform.

fromversion: 5.0.0
supportedModules:
- xsiam
- edr
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure edr, cloud, cloud_runtime_security, and cloud_posture are appropriate modules for Shodan? Shodan is primarily an Attack Surface Management (ASM) tool.

- No tests (auto formatted)
supportedModules:
- xsiam
- edr
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure edr, cloud, and cloud_runtime_security are appropriate modules for ExtraHop Reveal(x)? ExtraHop is primarily a Network Detection and Response (NDR) tool.

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • iManageThreatManager pack version was bumped to 1.0.2.
  • Halcyon pack version was bumped to 1.0.3.
  • HelloWorld pack version was bumped to 4.0.2.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • FireEyeHX pack version was bumped to 2.4.1.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@Shir2611 Shir2611 added the bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url label Apr 6, 2026
# Conflicts:
#	Packs/ManageEngine/ReleaseNotes/1_0_6.md
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need- it already has only xsiam supportedModules in pack metadata

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you need to remove the release notes and pack new version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

marketplaces:
- marketplacev2
- platform
supportedModules:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the 4 packs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added all supported but agentix as we have platfrom in marketplace but done have supported modules

fromversion: 8.3.0
tests:
- No tests (auto formatted)
supportedModules:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, pack doesn't have agentix

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added all supported but agentix as we have platfrom in marketplace but done have supported modules

@@ -107,3 +107,5 @@ marketplaces:
fromversion: 8.4.0
tests:
- No tests (auto formatted)
supportedModules:
- xsiam
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need, pack doesn't have agentix

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Shir2611 Shir2611 added the ForceMerge Forcing the merge of the PR despite the build status label Apr 12, 2026
@Shir2611
Copy link
Copy Markdown
Contributor Author

force merge as an effort to remove agentix from all event collectors

@content-bot
Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • ServiceNow pack version was bumped to 2.9.5.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were reported as warnings: BC117 (Approved).
✅ BC117 validation has been approved by PM review (supported-modules-approved label present).
The following errors were thrown as a part of this pr: DS104, DO106, ST111, BC115.
The following errors cannot be ignored: DS104, DO106, ST111, BC115.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: DS104, DO106, ST111, BC115.

Verdict: PR can be force merged from validate perspective? ✅

@jbabazadeh jbabazadeh merged commit c791659 into master Apr 13, 2026
20 of 21 checks passed
@jbabazadeh jbabazadeh deleted the remove-agentix-from-event-collectors-part-2 branch April 13, 2026 08:12
barryyosi-panw pushed a commit that referenced this pull request Apr 14, 2026
* removed agentix from event collectors

* Bump pack from version iManageThreatManager to 1.0.2.

* Bump pack from version Halcyon to 1.0.3.

* Bump pack from version HelloWorld to 4.0.2.

* Bump pack from version FireEyeHX to 2.4.1.

* merge from master

* added supported modules

* code review

* code review

* code review

* code review

* merge from master

* merge from master

* Bump pack from version ServiceNow to 2.9.5.

---------

Co-authored-by: Content Bot <bot@demisto.com>
mcvic1rj pushed a commit to mcvic1rj/xsoar-content that referenced this pull request Apr 16, 2026
* removed agentix from event collectors

* Bump pack from version iManageThreatManager to 1.0.2.

* Bump pack from version Halcyon to 1.0.3.

* Bump pack from version HelloWorld to 4.0.2.

* Bump pack from version FireEyeHX to 2.4.1.

* merge from master

* added supported modules

* code review

* code review

* code review

* code review

* merge from master

* merge from master

* Bump pack from version ServiceNow to 2.9.5.

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url docs-approved ForceMerge Forcing the merge of the PR despite the build status ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines supported-modules-approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants