Fix/XSUP-66433/ManageEngine refresh token update#43753
Conversation
… start/end date defaults, fix debug logs
- Fix root cause of XSUP-66433: Zoho OAuth rotating refresh tokens were
never updated in context. ctx.get('refresh_token') was always truthy so
the new token from the API response was silently discarded. After Zoho
invalidated the original token (within days), the integration stopped
ingesting events while still appearing connected.
- Fix get_events() start_date/end_date fallback defaults being swapped,
causing start > end when no dates provided (no events returned)
- Fix manage-engine-test command handler: change second 'if' to 'elif'
- Fix debug log: log len(events_page) instead of full event list
- Fix debug log typo: 'intervarl' -> 'interval'
… date defaults fixes
MosheEichler
added
release-notes-only
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
marketplace-ai-reviewer
removed
the
ready-for-ai-review
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi! Thanks for your contribution with the ManageEngine pack. I took a look at the changes and noticed a couple of quick fixes needed in the pack metadata. Specifically, please ensure the vendor name is added to the keywords list and include the mandatory created key. Let me know if you have any questions!
Additionally, please address the following file-level notes:
Packs/ManageEngine/pack_metadata.json: - Missing vendor name inkeywords.- Missing mandatory key
created.
@DeanArbel please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
MosheEichler
added
the
ready-for-pipeline-running
Co-authored-by: Richard Bluestone <53567272+richardbluestone@users.noreply.github.com>
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
5 participants
status
Related Issues
https://jira-dc.paloaltonetworks.com/browse/XSUP-66433
Description
Fix ManageEngine integration stopping log ingestion after a few days due to Zoho rotating refresh token not being updated.
Fixed an issue where in the
get_eventscommand defaultedstart_dateto now and end_date to now - 60s, making the time window inverted and returning no events when called without explicit dates.Must have