Skip to content

Fix/XSUP-63335/Unit 42 enrich by default#43754

Open
MosheEichler wants to merge 2 commits intomasterfrom
fix/XSUP-63335/unit-42-enrich-by-default
Open

Fix/XSUP-63335/Unit 42 enrich by default#43754
MosheEichler wants to merge 2 commits intomasterfrom
fix/XSUP-63335/unit-42-enrich-by-default

Conversation

@MosheEichler
Copy link
Copy Markdown
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/XSUP-63335

Description

Added default true to enrich indicator by default via unit 42

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler requested a review from DeanArbel March 31, 2026 13:47
@MosheEichler MosheEichler added release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines labels Mar 31, 2026
@MosheEichler MosheEichler marked this pull request as ready for review March 31, 2026 13:48
@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Mar 31, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Unit42ThreatIntelligencebyPaloAltoNetworks/Integrations/Unit42Intelligence
   Unit42Intelligence.py4016284%504, 881, 1063–1065, 1128–1130, 1193–1195, 1276–1278, 1307–1309, 1312–1316, 1319–1320, 1322, 1324–1325, 1331–1333, 1335–1341, 1343–1349, 1351–1352, 1354–1358, 1360–1366, 1369, 1371–1373
TOTAL4016284% 

Tests Skipped Failures Errors Time
91 0 💤 0 ❌ 0 🔥 2.896s ⏱️

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the Unit 42 Threat Intelligence pack! I've reviewed your changes and noticed a couple of minor formatting issues to tidy up. Specifically, there are a few indentation errors with the default: true keys in the integration YAML, and the release notes are missing the required content type header (e.g., #### Integrations). Let me know if you have any questions!

@DeanArbel please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

@MosheEichler MosheEichler enabled auto-merge (squash) March 31, 2026 17:03
@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅


##### Unit 42 Intelligence

- Fixed an issue where the ***domain***, ***url***, ***ip***, and ***file*** commands did not enrich indicators when triggered via the **Enrich** button or the ***enrichIndicators*** command.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed an issue where the ***domain***, ***url***, ***ip***, and ***file*** commands did not enrich indicators when triggered via the **Enrich** button or the ***enrichIndicators*** command.
- Fixed an issue where the ***domain***, ***url***, ***ip***, and ***file*** commands did not enrich indicators using the **Enrich** button or running the ***enrichIndicators*** command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants